Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Moved back simplified view prompt for regular tabs (uplift to 1.73.x) #26403

Open
wants to merge 2 commits into
base: 1.73.x
Choose a base branch
from
Open

[Android] Moved back simplified view prompt for regular tabs (uplift to 1.73.x) #26403

wants to merge 2 commits into from
+40 −0

Conversation

samartnik
Copy link
Contributor

Uplift of #26375
Resolves brave/brave-browser#42087

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@samartnik
[Android] Moved back simplified view prompt for regular tabs
3088c1b 
This is regression from this chromium change:
https://chromium.googlesource.com/chromium/src/+/c20ba57087f147b22a78a0fd916fdc4b887c2946

Cleanup Reader mode contextual page action

This CL cleans up ContextualPageActionReaderMode feature. There are
some details after the cleanup which can be summarized as :
1. Reader mode message UI is now only shown in CCT and incognito.
2. Finch param reader_mode_session_rate_limiting is set to
false. Hence it was removed in this CL.
3. CPA alternative color is also unused, but there are some feature
teams such as shopping who are interested in a similar experiment in
future. Hence it was kept as is.
4. There is also some code related to muting certain sites if the
user didn't take action. These are still needed for the message UI
that is shown for CCT and incognito.

Bug: 356237338
@samartnik
[Android] Fix for presubmit error
8b512d7
@samartnik samartnik added this to the 1.73.x - Release milestone Nov 6, 2024
@samartnik samartnik requested a review from a team as a code owner November 6, 2024 19:32
@samartnik samartnik mentioned this pull request Nov 6, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samartnik samartnik

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@samartnik @brave-builds